Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creation of zero-sized primitive Java arrays #85

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Support creation of zero-sized primitive Java arrays #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63abb4a
Support creation of zero-sized primitive Java arrays
niloc132 Aug 26, 2022
3a83533
Removing check entirely after review discussion
niloc132 Aug 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/main/c/jpy_jtype.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1938,13 +1938,6 @@ int JType_ConvertVarArgPyArgToJObjectArg(JNIEnv* jenv, JPy_ParamDescriptor* para
}

itemCount = pyBuffer->len / pyBuffer->itemsize;
if (itemCount <= 0) {
PyBuffer_Release(pyBuffer);
PyMem_Del(pyBuffer);
JPy_DECREF(pyArg);
PyErr_Format(PyExc_ValueError, "illegal buffer argument: not a positive item count: %ld", itemCount);
return -1;
}

if (paramComponentType == JPy_JBoolean) {
jArray = (*jenv)->NewBooleanArray(jenv, itemCount);
Expand Down Expand Up @@ -2281,12 +2274,6 @@ int JType_ConvertPyArgToJObjectArg(JNIEnv* jenv, JPy_ParamDescriptor* paramDescr
}

itemCount = pyBuffer->len / pyBuffer->itemsize;
if (itemCount <= 0) {
PyBuffer_Release(pyBuffer);
PyMem_Del(pyBuffer);
PyErr_Format(PyExc_ValueError, "illegal buffer argument: not a positive item count: %ld", itemCount);
return -1;
}

if (paramComponentType == JPy_JBoolean) {
jArray = (*jenv)->NewBooleanArray(jenv, itemCount);
Expand Down