Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releases/1.5.1 #1234
Releases/1.5.1 #1234
Changes from 43 commits
4d864a6
67890f4
0f58ace
0693b9b
2f48527
528863e
634bb64
6040496
7859017
d07579d
ece255d
8e0abe3
fb1bea3
89de434
793dede
5b63912
52e2c07
0905eb0
5d0c0ec
c07b225
85edcff
af12a14
35a1342
34a0c6d
b1c5f73
28e9ccd
5c1de82
fbe74cd
7334fef
8da632e
550e207
b255301
d6bca21
ecc9062
5676c22
90e2ff6
81f5ee6
e8f6ed3
b76471e
16ef2f7
9e597e4
b93b0e0
50fa58d
7c31d02
98d7acf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marscher this was a hidden two line fix. The problem it is addressing is that pytest is trying to do arithmetic. On linux systems we get -1 they subtract one then add one. No problem.
On windows system with the same version when we pass -1 to an integer field, we get None in the field. -2 works, 0 works, but -1 gives None. Then Pytest fails.
I think that we can fix this back in Java where we pass a line number 0 rather than -1. But it was easier to patch at this level in case there was some other way that we get invalid line numbers.
This seems like a typical left hand/right hand. Making -1 which was supposed to mean "line number not available" as None is completely reasonable. Trying to check the line numbers in the file (which happens to be 0 counting) for the audit display is perfectly reasonable in pytest. But both changes can't live together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the heck is this platform dependent? Oo