Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cleanups #1239

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Test cleanups #1239

merged 3 commits into from
Nov 19, 2024

Conversation

marscher
Copy link
Member

I just noticed that we have undefined references at some places in our code base. In this case the "first" and "second" argument in the overridden method were undefined.

This should also fix the float16 test failure which occurred every once in a while.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.19%. Comparing base (dfdeb76) to head (338c94b).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1239   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         113      113           
  Lines       10296    10296           
  Branches     4051     4051           
=======================================
  Hits         8978     8978           
  Misses        726      726           
  Partials      592      592           
---- 🚨 Try these New Features:

super useful: curl -X POST --data-binary @codecov.yml https://codecov.io/validate
@marscher marscher merged commit 29cce31 into jpype-project:master Nov 19, 2024
29 checks passed
@marscher marscher deleted the test_cleanups branch November 19, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant