Provide a jvp_dump_raw_string function to implement the combination o… #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f flags -r and -a (raw and ascii)
| @@ -114,13 +114,18 @@ static void put_indent(int n, int flags, FILE* fout, jv* strout, int T) { | |||
| } | |||
|
|
|||
| static void jvp_dump_string(jv str, int ascii_only, FILE* F, jv* S, int T) { | |||
| put_char('"', F, S, T); | |||
| jvp_dump_string_raw(str, ascii_only, F, S, T); | |||
There was a problem hiding this comment.
What happens if the string has double-quote characters in it?
There was a problem hiding this comment.
Oh, I guess this isn't new...
There was a problem hiding this comment.
That's actually a good question.. can jvp_dump_string be tricked into producing bad output?
|
Hey, thanks for this. |
bb010g
added a commit
to bb010g/jq
that referenced
this pull request
Oct 22, 2019
Escapes are still printed whenever characters outside the ASCII plane are encountered. To avoid ambiguity, backslash is the only ASCII character escaped (as `\\`). Fixes jqlang#1788, properly this time. Closes jqlang#1789.
bb010g
added a commit
to bb010g/jq
that referenced
this pull request
Oct 22, 2019
Escapes are still printed whenever characters outside the ASCII plane are encountered. To avoid ambiguity, backslash is the only ASCII character escaped (as `\\`). Fixes jqlang#1788, properly this time. Closes jqlang#1789.
Open
bb010g
added a commit
to bb010g/jq
that referenced
this pull request
Oct 26, 2019
Escapes are still printed whenever characters outside the ASCII plane are encountered. To avoid ambiguity, backslash is the only ASCII character escaped (as `\\`). Fixes jqlang#1788, properly this time. Closes jqlang#1789.
Alanscut
approved these changes
Dec 31, 2019
bb010g
added a commit
to bb010g/jq
that referenced
this pull request
Sep 20, 2020
Escapes are still printed whenever characters outside the ASCII plane are encountered. To avoid ambiguity, backslash is the only ASCII character escaped (as `\\`). Fixes jqlang#1788, properly this time. Closes jqlang#1789.
bb010g
added a commit
to bb010g/jq
that referenced
this pull request
Sep 20, 2020
Escapes are still printed whenever characters outside the ASCII plane are encountered. To avoid ambiguity, backslash is the only ASCII character escaped (as `\\`). Fixes jqlang#1788, properly this time. Closes jqlang#1789.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f flags -r and -a (raw and ascii)