Fix to incorrect --stream paths #2010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thought something was wrong with the example provided against the --stream option. Proved that the index of the path to "b" was incorrect by running the example on the terminal. Instead of `[[1,0],"b"]` it should read `[[2,0],"b"]` . Additionally, this isn't the whole stream, as given it's depth-first, after visiting descendants, it will visit the ancestor containers too. However I guess these have been omitted deliberately for brevity? If you prefer the full sequence I'll force push a fix to this PR branch which contains the ancestors traversed too. ## Example in terminal ``` echo '[[],"a",["b"]]' | jq --stream --compact-output [[0],[]] [[1],"a"] [[2,0],"b"] [[2,0]] [[2]] ```
Alanscut
suggested changes
Dec 20, 2019
docs/content/manual/manual.yml
Outdated
Comment on lines
119
to
120
| `[[],"a",["b"]]` becomes `[[0],[]]`, `[[1],"a"]`, and | ||
| `[[2,0],"b"]`. |
There was a problem hiding this comment.
`[[],"a",["b"]]` becomes `[[0],[]]`, `[[1],"a"]`, `[[2,0],"b"]`,
`[[2,0]]` and `[[2]]`.
Prompted by... jqlang#2010 (comment)
This was referenced Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought something was wrong with the example provided against the --stream option. Proved that the index of the path to "b" was incorrect by running the example on the terminal. Instead of
[[1,0],"b"]it should read[[2,0],"b"].Additionally, this isn't the whole stream. Given it's a depth-first traversal, after visiting descendants, it will visit the paths of the ancestors too. However I guess these have been omitted deliberately for brevity?
If you prefer the full sequence I'll force push a fix to this PR branch which contains the ancestor paths traversed too.
Example in terminal