Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora link returns 404 #2067

Merged
merged 1 commit into from
Jun 16, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/download/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ body:
`sudo apt-get install jq`.

* jq 1.5 is in the official
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually at 1.6.4 now in Fedora 32

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't released any revisions to 1.6- that -4 is referring to the version of the RPM itself. That said, this should say 1.6 instead of 1.5. Mind updating it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtlangford , since this seems to be a dead PR. I've confirmed here https://src.fedoraproject.org/rpms/jq/blob/master/f/sources that Fedora is using jq v1.6

Suggested change
* jq 1.5 is in the official
* jq 1.6 is in the official

Can you accept the GH suggestion and we get this closed, or would you prefer I make a new PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't released any revisions to 1.6- that -4 is referring to the version of the RPM itself. That said, this should say 1.6 instead of 1.5. Mind updating it?

Apologies, I thought I had already done the update and you had to accept the PR?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I thought I had already done the update and you had to accept the PR?

@calpeconsulting The change in the PR still refers to jq 1.5. It needs to be jq 1.6.

[Fedora](http://pkgs.fedoraproject.org/cgit/jq.git/) repository.
[Fedora](https://src.fedoraproject.org/rpms/jq) repository.
Install using `sudo dnf install jq`.

* jq 1.4 is in the official [openSUSE](https://software.opensuse.org/package/jq)
Expand Down