Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show missing backslash in manual #2492

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Show missing backslash in manual #2492

merged 1 commit into from
Jun 5, 2023

Conversation

zstadler
Copy link
Contributor

The 1.6 manual about sub(regex;tostring) currently says:

a reference to a captured variable named "x" would take the form: "(.x)".

Using "(.x)" produces this string literally rather than the captured variable. Instead, the manual should say:

a reference to a captured variable named "x" would take the form: "\(.x)".

This PR may also need to be back-ported to earlier versions of the jq manual as well as ported to the development version of the jq manual.

The 1.6 manual about [`sub(regex;tostring)`](https://stedolan.github.io/jq/manual/#sub(regex;tostring)sub(regex;string;flags)) currently says:

> a reference to a captured variable named "x" would take the form: "(.x)".

Using `"(.x)"` produces this string literally rather than the captures variable. Instead, the manual should say:

> a reference to a captured variable named "x" would take the form: `"\(.x)"`.

This PR may also need to be back-ported to earlier versions of the jq manual as well as ported to the development version of the jq manual.
@zstadler
Copy link
Contributor Author

As far as I can tell, the CI failure has nothing to do with the contents of this PR

C:\msys64\usr\bin\bash -lc "pacman-key --verify msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig"
==> Checking msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig...
gpg: no valid OpenPGP data found.
gpg: the signature could not be verified.
Please remember that the signature file (.sig or .asc)
should be the first file given on the command line.
==> ERROR: The signature identified by msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig could not be verified.
Command exited with code 1
cat config.log
cat: config.log: No such file or directory
Command exited with code 1

@zstadler
Copy link
Contributor Author

zstadler commented Nov 8, 2022

@stedolan, @nicowilliams

Please look at this documentation fix PR.

The failure in the CI check is unrelated to the change in the README.md file,

@wader
Copy link
Member

wader commented Nov 8, 2022

Fix LGTM but have no access to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants