Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/Pipfile.lock #2693

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

emanuele6
Copy link
Member

@emanuele6 emanuele6 commented Jul 10, 2023

This fixed my pipenv install issue with python 3.11. I simply ran pipenv lock to bump the dependencies.

@emanuele6
Copy link
Member Author

After bumping the dependencies, the deprecation warnings of #2692, become ImporErrors :(

$ (source venv/bin/activate && (cd ../docs && pipenv install && pipenv run python build_website.py))
Courtesy Notice: Pipenv found itself running within a virtual environment, so it will automatically use that environment, instead of creating its own for any project. You can set PIPENV_IGNORE_VIRTUALENVS=1 to force pipenv to ignore that environment and create its own instead. You can set PIPENV_VERBOSITY=-1 to suppress this warning.
Installing dependencies from Pipfile.lock (62a1ce)...
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
Courtesy Notice: Pipenv found itself running within a virtual environment, so it will automatically use that environment, instead of creating its own for any project. You can set PIPENV_IGNORE_VIRTUALENVS=1 to force pipenv to ignore that environment and create its own instead. You can set PIPENV_VERBOSITY=-1 to suppress this warning.
Traceback (most recent call last):
  File "/home/emanuele6/.source_code/jq/docs/build_website.py", line 4, in <module>
    from jinja2 import Environment, FileSystemLoader, Markup, select_autoescape, contextfunction
ImportError: cannot import name 'Markup' from 'jinja2' (/home/emanuele6/.source_code/jq/build/venv/lib/python3.11/site-packages/jinja2/__init__.py)

@nicowilliams nicowilliams merged commit 7fba850 into jqlang:master Jul 10, 2023
24 checks passed
@nicowilliams
Copy link
Contributor

Thanks!

@nicowilliams
Copy link
Contributor

After bumping the dependencies, the deprecation warnings of #2692, become ImporErrors :(

Oh no. Maybe I shouldn't have merged this :/

@nicowilliams
Copy link
Contributor

Well, if we don't fix these in time for 1.7 we can revert this locally to make the website.

@nicowilliams
Copy link
Contributor

Hmm, I've reverted this as it did break the GHA workflow we have for website updates.

@emanuele6 emanuele6 deleted the updatepipfilelock branch July 10, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants