Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug/1 #2710

Merged
merged 2 commits into from
Jul 13, 2023
Merged

debug/1 #2710

merged 2 commits into from
Jul 13, 2023

Conversation

pkoppstein
Copy link
Contributor

@pkoppstein pkoppstein commented Jul 13, 2023 •
edited by emanuele6
Loading

This def ensures the output of debug(m1,m2) is kept together.

Resolves #2709, resolves #2111, closes #2112

emanuele6
emanuele6 reviewed Jul 13, 2023
View reviewed changes
docs/content/manual/manual.yml Outdated Show resolved Hide resolved
src/builtin.jq Outdated Show resolved Hide resolved
@emanuele6
Copy link
Member

emanuele6 commented Jul 13, 2023 •
edited
Loading

You also need to regenerate jq.1.prebuilt after having modified manual.yml.
workflows/manpage.yml was incorrectly configured to only run on push, and not on pull requests so the CI for this PR is green even though it is red on your fork https://github.com/pkoppstein/jq/actions/runs/5538611539/jobs/10108730569

55249e2 should fix that.

emanuele6
emanuele6 reviewed Jul 13, 2023
View reviewed changes
docs/content/manual/manual.yml Outdated Show resolved Hide resolved
docs/content/manual/manual.yml Outdated Show resolved Hide resolved
docs/content/manual/manual.yml Outdated Show resolved Hide resolved
@itchyny
Copy link
Contributor

itchyny commented Jul 13, 2023

Some tests could be added to shtest?

@pkoppstein
Copy link
Contributor Author

pkoppstein commented Jul 13, 2023 •
edited
Loading

Some tests could be added to shtest?

There aren't any for debug so that's one reason I didn't reach out for help. I don't know how to test shtest - it uses VALGRIND. Please feel free to add.

@nicowilliams
Copy link
Contributor

I'm ok with the continued lack of tests for debug -- partly it's because its output form shouldn't really be considered stable, and partly because it is meant to have no impact on the jq program itself and what it does. But if you'd like to write a test go ahead, otherwise we should merge this.

@pkoppstein
debug/1
c248fe3 
This def ensures the output of debug(m1,m2) is kept together.

See jqlang#2709 jqlang#2111 jqlang#2112

Update jq.1.prebuilt

manual.yml: debug/1: more typos

manual.yml: debug/1: typo

msgs

builtin.jq: spacing

manual.yml: more tweaking
@emanuele6 emanuele6 merged commit 07ef97c into jqlang:master Jul 13, 2023
This was referenced Jul 13, 2023
Closed
Closed
@pkoppstein pkoppstein deleted the debug branch July 14, 2023 01:16
@yertto yertto mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emanuele6 emanuele6 emanuele6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ER: debug/1 Feature request: Add 1-arity built-in function debug(f) for more control over debug output
4 participants
@pkoppstein @emanuele6 @itchyny @nicowilliams