Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit GPG signatures on release #2778

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Jul 27, 2023

I improved the release job to GPG sign and commit the artifact signatures to the repository. Note that the secret names are slightly different from what is currently registered.

@itchyny itchyny added this to the 1.7 release milestone Jul 27, 2023
@itchyny itchyny changed the title Commit signatures on release Commit GPG signatures on release Jul 27, 2023
@nicowilliams
Copy link
Contributor

Ok, let's test this. This should make a release for master, yes? I'll merge and find out!

@nicowilliams nicowilliams merged commit 4160a36 into jqlang:master Jul 27, 2023
28 checks passed
@nicowilliams
Copy link
Contributor

Thanks!

@itchyny
Copy link
Contributor Author

itchyny commented Jul 27, 2023

This is triggered on pushing the release tag so maybe we can test with jq-1.7rc1. If you're busy I'll make a GPG key but what kind of key are you using? RSA 4096bits or ECC Curve25519?

@nicowilliams
Copy link
Contributor

nicowilliams commented Jul 27, 2023

I just pushed a jq-1.7rc1 tag. If it works I'll make a new key since then I've nothing else to do for this :) :)

Now [if this works] I don't have to waste any time this weekend on this! Thank you!

@itchyny
Copy link
Contributor Author

itchyny commented Jul 27, 2023

Sorry I should have emphasized that I changed the secret name. JQ_RELEASE_GPG_PRIVATE_KEY and JQ_RELEASE_GPG_PASSPHRASE.

@itchyny
Copy link
Contributor Author

itchyny commented Jul 27, 2023

You don't need re-tagging. You can register the keys in the release environment with the new names, and approve https://github.com/jqlang/jq/actions/runs/5686058422 after that.

@itchyny
Copy link
Contributor Author

itchyny commented Jul 27, 2023

@owenthereal approved without noticing this thread, but that's Okay. Firstly Nico registers the keys with the new names, and then Re-run https://github.com/jqlang/jq/actions/runs/5686058422 from failed, and approve it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants