Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execute.c: support pick(last) #2779

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

pkoppstein
Copy link
Contributor

Support [0] | setpath([-1]; _)
Add tests for pick/1

Supersedes #2717

jv_free(k);
k = jv_number(jv_array_length(jv_copy(t)) + idx);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch should be authored by @nicowilliams

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emanuele6 - It was.

@nicowilliams
Copy link
Contributor

@pkoppstein please do nothing. I'll push my version of this with attribution to you.

@nicowilliams
Copy link
Contributor

nicowilliams commented Jul 27, 2023

.

@nicowilliams
Copy link
Contributor

Ok, @pkoppstein I've force-pushed to this PR. Please do not push to it again. Just tell me if it now has the contents that you wanted. If it does then I'll merge it after all the tests pass.

@emanuele6 emanuele6 added this to the 1.7 release milestone Jul 27, 2023
@nicowilliams
Copy link
Contributor

@pkoppstein I've added the following wiki page for you: https://github.com/jqlang/jq/wiki/Guide-for-Contributors

@pkoppstein
Copy link
Contributor Author

@nicowilliams wrote:

Just tell me if it now has the contents that you wanted. If it does then I'll merge it after all the tests pass.

It's missing one minor comment, but that's OK. I see that "All checks have passed" so please merge it before things get complicated again. Thank you.

@nicowilliams
Copy link
Contributor

It's missing one minor comment, but that's OK. I see that "All checks have passed" so please merge it before things get complicated again. Thank you.

OK, we're in the middle of trying to create a signed jq-1.7rc1. We'll merge this after that.

@nicowilliams nicowilliams merged commit 336c3de into jqlang:master Jul 28, 2023
@pkoppstein pkoppstein mentioned this pull request Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants