-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
execute.c: support pick(last) #2779
Conversation
jv_free(k); | ||
k = jv_number(jv_array_length(jv_copy(t)) + idx); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch should be authored by @nicowilliams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emanuele6 - It was.
@pkoppstein please do nothing. I'll push my version of this with attribution to you. |
. |
Ok, @pkoppstein I've force-pushed to this PR. Please do not push to it again. Just tell me if it now has the contents that you wanted. If it does then I'll merge it after all the tests pass. |
@pkoppstein I've added the following wiki page for you: https://github.com/jqlang/jq/wiki/Guide-for-Contributors |
@nicowilliams wrote:
It's missing one minor comment, but that's OK. I see that "All checks have passed" so please merge it before things get complicated again. Thank you. |
OK, we're in the middle of trying to create a signed |
Support [0] | setpath([-1]; _)
Add tests for pick/1
Supersedes #2717