Require a main program (fix #2785) #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't go so far as to say that this has to be in 1.7. |
emanuele6
reviewed
Jul 29, 2023
nicowilliams
force-pushed
the
fix_2785
branch
3 times, most recently
from
6709b0f
to
f7e40af
Compare
itchyny
reviewed
Jul 31, 2023
src/linker.c
Outdated
| @@ -407,6 +407,12 @@ int load_program(jq_state *jq, struct locfile* src, block *out_block) { | |||
| if (nerrors) | |||
| return nerrors; | |||
|
|
|||
| if (!block_has_main(program)) { | |||
| jq_report_error(jq, jv_string("jq: error: Top-level program not given (try \".\")\n")); | |||
There was a problem hiding this comment.
I don't think we need a newline at the end because err_cb prints with it.
itchyny
approved these changes
Jul 31, 2023
|
Pushing w/o waiting for checks to save builder minutes. |
itchyny
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.