Fix typo in CI env vars for Linux build #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, the env vars are set correctly without refering the variable in `matrix` case-sensitvely: ``` 2023-08-01T05:05:58.4626090Z env: 2023-08-01T05:05:58.4626367Z AR: arm-linux-gnueabihf-ar 2023-08-01T05:05:58.4626690Z CHOST: arm-linux-gnueabihf 2023-08-01T05:05:58.4626961Z CC: arm-linux-gnueabihf-gcc 2023-08-01T05:05:58.4627332Z CPP: arm-linux-gnueabihf-cpp 2023-08-01T05:05:58.4627662Z CXX: arm-linux-gnueabihf-g++ ``` For clarify, we update them to match the definitions. Besides, `CXX` is not needed and removed.
wader
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the env vars are set correctly without refering the variable in
matrixcase-sensitvely:For clarify, we update them to match the definitions. Besides,
CXXis not needed and removed.Thanks @wader for spotting the typos!