Add --config option printing ./configure options used #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicowilliams
force-pushed
the
add--config-option
branch
from
df45a71
to
8f81acd
Compare
itchyny
reviewed
Aug 3, 2023
nicowilliams
force-pushed
the
add--config-option
branch
2 times, most recently
from
507f43b
to
2232b47
Compare
|
This resolves #2816 but assigned milestones are different. |
|
Milestones now line up. |
wader
reviewed
Aug 17, 2023
wader
reviewed
Aug 17, 2023
There was a problem hiding this comment.
Except my comment i think it looks good 👍
btw for fq i expose some or these things using a function that return an structure with various information that is then used by the cli code written in jq code, kind of nice. Maybe could be interesting in the future? maybe not cli in jq but expose things as a function or $global
nicowilliams
force-pushed
the
add--config-option
branch
from
2232b47
to
873a2f0
Compare
|
Now with |
wader
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could add lines recording compiler name and version, flex/bison version, autotools versions, etc.
Closes #2816.