Change the default color of null to Bright Black #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
force-pushed
the
change-default-null-color
branch
from
7311a7c to
fc7ecf7
Compare
itchyny
force-pushed
the
change-default-null-color
branch
from
fc7ecf7 to
a089539
Compare
wader
approved these changes
Aug 5, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been multiple reports about the default color of
nullon dark background (#1252, #1972, #2113). Currentlynullis colored by\e[1;30m, which means bold (or increased intensity) black, and is totally invisible on some terminals (e.x. Terminal.app with Homebrew/Pro profile). I think we could improve thenullcolor for the better defaults, I choose\e[0;90m, which means normal bright black. This color should look better on dark background color schemes.This PR resolves #1252, resolves #1972, and resolves #2113.