Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-standard pow10 filter in favor of exp10 #3059

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Mar 7, 2024

The pow10(3) function is a non-standard glibc extension removed in 2.27. Listing in the manual often confuses users like #2456, #2566. The exp10(3) function was a glibc extension too, but is standardized in TS 18661-4:2015 and expected to be available widely.

@itchyny itchyny added this to the 1.8 release milestone Mar 8, 2024
@emanuele6
Copy link
Member

Maybe we could add a note in the manual that explains that exp10 is equivalent to pow10, but more likely to be implemented?

@wader
Copy link
Member

wader commented Mar 20, 2024

Some reason pow10 can't be an alias for exp10?

@itchyny
Copy link
Contributor Author

itchyny commented Mar 20, 2024

I prefer making implemenetation clean, there are exp/0, exp2/0 so exp10/0 is easy to remember (even if pow/2 exists), another reason is pow10/0 has not been available in many environments, so I don't think it's important to keep compatibility.

@wader
Copy link
Member

wader commented Mar 20, 2024

@itchyny Ok makes sense, i'm fine with removing it

@itchyny
Copy link
Contributor Author

itchyny commented Mar 20, 2024

Thank you.

@itchyny itchyny merged commit 81f4f88 into jqlang:master Mar 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants