Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Min and Max cause bugs in Current Time Indicator #1297

Closed

Conversation

aminland
Copy link

Ensure that changes in min and max time is reflected when computing the Now indicator

@aminland aminland force-pushed the fix-timeindicator-position branch from f9bef4b to 86e3de8 Compare April 29, 2019 18:41
@arecvlohe
Copy link
Collaborator

@aminland Since I am not familiar with this issue can you provide steps to reproduce the error.

@sonnyp
Copy link
Contributor

sonnyp commented May 13, 2019

related: #1311

@aminland
Copy link
Author

aminland commented Jun 4, 2019

Sorry, didnt see this.

Steps to reproduce are, have a calendar, and set the min and max time to some dynamic value. You will note that the current time indicator bar does not update to the correct position till the next minute passes.

In our usage for each day, the min and max time are different (We dynamically compute what time range to display based on when there are events.)

The other PR #1311 would address this also in the min case, so feel free to close this out if you like that solution.

@stale
Copy link

stale bot commented Aug 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 3, 2019
@jquense jquense closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants