Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new Calendar prop: doShowMoreDrillDown #1850

Merged
merged 1 commit into from
May 27, 2021
Merged

feat: Add new Calendar prop: doShowMoreDrillDown #1850

merged 1 commit into from
May 27, 2021

Conversation

teryngull
Copy link

Setting popup={false} doesn't let you control the onShowMore function properly as described in #1147 and #1527 , because it only goes to the drill down view. In order to fix this, I've added another prop called doShowMoreDrillDown that is defaulted to true. If true, it will do the same thing it currently does, and go to the drill down view. However, if you set this prop to false, it will instead just trigger the onShowMore function where you can then show your own customized popup as desired.
Fixes #1147
Fixes #1527

@teryngull
Copy link
Author

@jquense can you take a look at this when you get a chance? we'd love to get this in so we can properly control and do our own 'show more' popup without also performing the drill down to the day view.

Copy link

@thomasmi thomasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this PR and it seems like an unintrusive change, by default the code works the same and the new behavior is opt-in. My team would also greatly benefit from this change as we need to use a custom dialog. How can we get this merged?

@pietrofxq
Copy link
Collaborator

@teryngull please update commit to follow conventional commit standard and we can merge

@teryngull teryngull changed the title Add new Calendar prop: doShowMoreDrillDown feat: Add new Calendar prop: doShowMoreDrillDown May 27, 2021
@teryngull
Copy link
Author

@pietrofxq I had adjusted the commit message accordingly. Please let me know if I need do anything else. Thank you!

@pietrofxq pietrofxq merged commit 7e87e48 into jquense:master May 27, 2021
@github-actions
Copy link

🎉 This PR is included in version 0.33.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

popup = {false} brings up day view show more popup customize
3 participants