Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Create event] fix end date on slot selection #1910

Merged
merged 2 commits into from
May 27, 2021

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Apr 10, 2021

For end date in month-view slot-selection increase day by 1.

Fixes: #1909

EDIT: The fix is applied for Month View, whole days Week view, whole day in Day view.

@Virthuss
Copy link

Is this going to be merged? I need this fux.

@pietrofxq
Copy link
Collaborator

@croraf you mentioned in the issue you also applied the fix for Week view but this PR has only changes for month, do you want to push more changes?

@croraf
Copy link
Contributor Author

croraf commented May 27, 2021

@pietrofxq The change I did in src/TimeGrid.js file handles that case. The problem for week was only in the selection of entire day row (the topmost row as per bottom image) .

image

The same missalignment was in Day view for the whole day selection row (topomost row). This is also fixed now:
image

@croraf croraf changed the title [Month View] fix end date in slot selection [Create event] fix end date on slot selection May 27, 2021
@pietrofxq pietrofxq merged commit 2148e86 into jquense:master May 27, 2021
@github-actions
Copy link

🎉 This PR is included in version 0.33.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrectly shortening the multi-day event time-slot span by 1 day
3 participants