Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] export printValue function from the bundle #2002

Closed
diegoulloao opened this issue May 12, 2023 · 3 comments
Closed

[request] export printValue function from the bundle #2002

diegoulloao opened this issue May 12, 2023 · 3 comments

Comments

@diegoulloao
Copy link

diegoulloao commented May 12, 2023

Describe the bug
I have a yup "es" translation library that uses the printValue function from yup, it used to work in older versions where this function was exported but it doesn't anymore.

Some projects are depending of this translation library I've created, they can't update to the latest yup version.

This printValue function has other dependencies like printSimpleValue and I don't think is a good idea to just copy and paste those function definitions into my code in order to do the fix.

I'm requiring from yup to export this printValue function in the bundle in order to allow translation packages that uses this function to work properly.

If you want to know more about this package (which is very simple), please follow this link: https://github.com/diegoulloao/yup-es

This is the related issue: diegoulloao/yup-es#7

It is possible from you to consider this petition?

Thank you for your time.

@jquense
Copy link
Owner

jquense commented May 13, 2023

Happy to expose this, want to send a PR?

dilanluna added a commit to dilanluna/yup that referenced this issue May 23, 2023
dilanluna added a commit to dilanluna/yup that referenced this issue May 23, 2023
@diegoulloao
Copy link
Author

diegoulloao commented Jun 14, 2023

Hey @jquense, just coming back to this, I was tied up in my work.
I can see you pushed a commit that exposes the function. What's the release status?

@diegoulloao
Copy link
Author

Ok seems like fixed in this version: https://github.com/jquense/yup/releases/tag/v1.2.0
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants