Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): use named functions for default exports #1329

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

blurrah
Copy link
Contributor

@blurrah blurrah commented Apr 8, 2021

There's ESLint rules that warn on exporting an anonymous arrow function (See #1161)

While I agree this does not break anything, it seems like a very small fix that does not impact yup and fixes a lot of console spam coming from NextJS (and maybe other projects that check for anonymous functions with fast refresh).

@jquense jquense merged commit acbb8b4 into jquense:master Apr 8, 2021
@jquense
Copy link
Owner

jquense commented Apr 8, 2021

thanks!

@blurrah blurrah deleted the remove-anonymous-default-exports branch April 12, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants