Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide keys in default noUnknown message #579

Merged
merged 1 commit into from
Mar 13, 2020
Merged

feat: provide keys in default noUnknown message #579

merged 1 commit into from
Mar 13, 2020
+7 −3

Conversation

doomsower
Copy link
Contributor

Currently noUnknown does not provide the list of unknown key, which makes it very hard to debug. This PR fixes it.

@andrey-hohlov
Copy link

🙏

@jquense
Copy link
Owner

jquense commented Mar 13, 2020

missed this! great addition thanks!

@jquense jquense merged commit ad5d015 into jquense:master Mar 13, 2020
@msheakoski
Copy link

Thanks for this PR! I ran into this issue today. @jquense would it be possible to publish a release with this change?

I attempted to use https://github.com/jquense/yup#ad5d015 as the version in my package.json but did not have any luck since the package needs to be built to generate a lib/index.js

@icflorescu icflorescu mentioned this pull request Apr 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doomsower @andrey-hohlov @jquense @msheakoski