Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Fixing some typos at docs/about/getting-started and propose an explanation for the apparently overwritten collapsible paragraph #3089

Merged
merged 1 commit into from
Nov 17, 2011

Conversation

MauriceG
Copy link
Contributor

No description provided.

toddparker added a commit that referenced this pull request Nov 17, 2011
Fixing some typos at docs/about/getting-started and propose an explanation for the apparently overwritten collapsible paragraph.
@toddparker toddparker merged commit c5213aa into jquery-archive:master Nov 17, 2011
@toddparker
Copy link
Contributor

Thanks for fixing my 2am typos.

@MauriceG
Copy link
Contributor Author

@toddparker You are very welcome! I've recognized when you've committed that page and I'm surprised that you already at the console again.
But it's a nice and easy to understand introduction. Good job.

@MauriceG
Copy link
Contributor Author

@toddparker One other thing: @Wilto has divided the select menu page into two parts yesterday (native and custom).
I see some issues there and I would like to create a pull for that. But for full integration of the new custom.html I would
extend the form buttons on top like:
Menu
Or would you prefer to integrate that page in the Main-Menu?
But then the option/methods/events pages would be the same as for native-selects and may gives the impression,
that custom-selects have other events/methods etc.

@toddparker
Copy link
Contributor

I'm trying to downplay them a bit but I agree we could improve. Nit sure if that nav would fit on a phone - did you test?

At the least, we could improve the headings

.................................. . . . .
Todd Parker
Partner, Filament Group Inc.
102 South Street #3 Boston, MA 02111
todd@filamentgroup.com // 617.953.1617

On Nov 17, 2011, at 9:20 AM, "Maurice Gottlieb" reply@reply.github.com wrote:

@toddparker One other thing: @Wilto has divided the select menu page into two parts yesterday (native and custom).
I see some issues there and I would like to create a pull for that. But for full integration of the new custom.html I would
extend the form buttons on top like:
Menu
Or would you prefer to integrate that page in the Main-Menu?
But then the option/methods/events pages would be the same as for native-selects and may gives the impression,
that custom-selects have other events/methods etc.


Reply to this email directly or view it on GitHub:
#3089 (comment)

@MauriceG
Copy link
Contributor Author

I've tested right now, it does not fit in portrait. So, this is not an option.

@toddparker
Copy link
Contributor

I just made a few quick tweaks for now. Open to re-thinking this though.

@MauriceG
Copy link
Contributor Author

Another quicky tweak what may be a second ul-controlgroup like:
Menu

btw:

1.0 ! Congratulations!

@toddparker
Copy link
Contributor

I appreciate this, but I don't want to emphasize custom select this much because it's sort of an extension to select and it has some limitations. Thanks!

@MauriceG
Copy link
Contributor Author

Oh I see ... because I want to emphasize them, I was trying to get the custom-select page better implemented.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants