Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Update docs/forms/forms-sample.html #3574

Closed
wants to merge 1 commit into from

Conversation

agcolom
Copy link
Contributor

@agcolom agcolom commented Feb 13, 2012

added missing backet

@toddparker
Copy link
Contributor

@agcolom - can you add [docs] to each doc commit message so we can cherry pick them to maintenance releases? Actually - only use this for doc fixes that should be pulled into 1.0.x which these shouldn't.

@agcolom
Copy link
Contributor Author

agcolom commented Feb 13, 2012

ok, will do. Is it in the 1st or second box? (I can't remember what they're called...)
Which ones are not going into 1.0.x?

@agcolom
Copy link
Contributor Author

agcolom commented Feb 13, 2012

just for clarification, the 1st box has Update docs/forms/forms-sample.html by default, the second box is where I would normally say what I've changed...

@toddparker
Copy link
Contributor

Either box is fine. So if it's a docs edit for a new feature for 1.1 then you wouldn't add that tag. We should use it for edits that should be applied back to the last version too.

.................................. . . . .
Todd Parker
Partner, Filament Group Inc.
102 South Street #3 Boston, MA 02111
todd@filamentgroup.com // 617.953.1617

On Feb 13, 2012, at 6:50 PM, "Anne-Gaelle Colom" reply@reply.github.com wrote:

just for clarification, the 1st box has Update docs/forms/forms-sample.html by default, the second box is where I would normally say what I've changed...


Reply to this email directly or view it on GitHub:
#3574 (comment)

@agcolom
Copy link
Contributor Author

agcolom commented Feb 15, 2012

Can this be merged? Thanks :-)

@toddparker
Copy link
Contributor

Looks like there's a merge conflict. Could you submit a fresh pull? Sorry, thought I had pulled this.

@toddparker toddparker closed this Feb 16, 2012
@agcolom
Copy link
Contributor Author

agcolom commented Feb 16, 2012

ok will do... tomorrow (it's 1.50am!) I'm a bit dead... I'll probably make mistakes if I do it now :-)

@agcolom
Copy link
Contributor Author

agcolom commented Feb 16, 2012

Done with request #3591

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants