This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Unset light shadow for input clear button and slider handle. #4813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toddparker - Can I remove the bottom glow style? |
|
Let's prototype this in a branch and decide. .................................. . . . . On Aug 8, 2012, at 4:54 AM, "Jasper de Groot" notifications@github.com wrote:
|
|
Test page to compare bottom glow (current) versus dark shadow: http://jsbin.com/atahip/77 |
ghost
assigned
|
Let's discuss for 1.3 what's best approach here. Closing this PR for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The light shadow for buttons in a theme A, B or C toolbar is also applied to the clear button of the search input and the slider handle (see: http://jsbin.com/atahip/65)
@toddparker
I have been looking for a solution without adding specific element classes to theme CSS, but didn't see any.
Applying the light shadow style only to buttons that are immediate children of the toolbar (
.ui-bar-a > .ui-shadow) would fix the problem, but also create new ones.Can I merge this PR?