Skip to content

Commit

Permalink
Effect: Remove demos & visual tests of the transfer effect
Browse files Browse the repository at this point in the history
The transfer effect is deprecated and not present unless `$.uiBackCompat` is set
to `true`. In previous UI versions, the default was including the backwards
compat layer so these demos & tests worked; now they do not by default. Just
remove them.

Fixes gh-2278
Closes gh-2291
  • Loading branch information
mgol authored Sep 16, 2024
1 parent c934995 commit 36ed9fc
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 18 deletions.
4 changes: 0 additions & 4 deletions demos/effect/default.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#button { padding: .5em 1em; text-decoration: none; }
#effect { width: 240px; height: 170px; padding: 0.4em; position: relative; }
#effect h3 { margin: 0; padding: 0.4em; text-align: center; }
.ui-effects-transfer { border: 2px dotted gray; }
</style>
<script src="../../external/requirejs/require.js"></script>
<script src="../bootstrap.js" data-modules="effects-all">
Expand All @@ -25,8 +24,6 @@
// some effects have required parameters
if ( selectedEffect === "scale" ) {
options = { percent: 50 };
} else if ( selectedEffect === "transfer" ) {
options = { to: "#button", className: "ui-effects-transfer" };
} else if ( selectedEffect === "size" ) {
options = { to: { width: 200, height: 60 } };
}
Expand Down Expand Up @@ -75,7 +72,6 @@ <h3 class="ui-widget-header ui-corner-all">Effect</h3>
<option value="shake">Shake</option>
<option value="size">Size</option>
<option value="slide">Slide</option>
<option value="transfer">Transfer</option>
</select>

<button id="button" class="ui-state-default ui-corner-all">Run Effect</button>
Expand Down
6 changes: 0 additions & 6 deletions tests/visual/effects/all.html
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,6 @@
</div>
</li>

<li>
<div class="effect" id="transfer">
<p>Transfer to first element</p>
</div>
</li>

<li>
<div class="effect" id="addClass">
<p>addClass</p>
Expand Down
8 changes: 0 additions & 8 deletions tests/visual/effects/effects.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,6 @@ effect( "#slideUp", "slide", { direction: "up" } );
effect( "#slideLeft", "slide", { direction: "left" } );
effect( "#slideRight", "slide", { direction: "right" } );

$( "#transfer" ).on( "click", function() {
$( this )
.addClass( "current" )
.effect( "transfer", { to: $( "div" ).eq( 0 ) }, 1000, function() {
$( this ).removeClass( "current" );
} );
} );

$( "#addClass" ).on( "click", function() {
$( this ).addClass( "current", duration, function() {
$( this ).removeClass( "current" );
Expand Down

0 comments on commit 36ed9fc

Please sign in to comment.