Skip to content

Commit

Permalink
Tests: Increase robustness of a draggable revert test
Browse files Browse the repository at this point in the history
One of the changes is increasing `revertDuration` from 200 to 300. For some
reason, when jQuery 3.1 is used in an iframe (which TestSwarm uses) the timings
are lower than expected and `setTimeout` too slow and the check for animation
happens too late.

Closes gh-2230
  • Loading branch information
mgol authored Apr 12, 2024
1 parent ab2a2a9 commit e7a0da6
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tests/unit/draggable/options.js
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,7 @@ QUnit.test( "opacity, default, switching after initialization", function( assert
} );

QUnit.test( "revert and revertDuration", function( assert ) {
var ready = assert.async();
var ready = assert.async( 2 );
assert.expect( 7 );

var element = $( "#draggable2" ).draggable( {
Expand All @@ -1035,7 +1035,7 @@ QUnit.test( "revert and revertDuration", function( assert ) {

$( "#draggable2" ).draggable( "option", {
revert: true,
revertDuration: 200,
revertDuration: 300,
stop: function() {
ready();
}
Expand All @@ -1045,6 +1045,7 @@ QUnit.test( "revert and revertDuration", function( assert ) {
testHelper.move( element, 50, 50 );
setTimeout( function() {
assert.ok( $( "#draggable2" ).is( ":animated" ), "revert: true with revertDuration should animate" );
ready();
} );
} );

Expand Down

0 comments on commit e7a0da6

Please sign in to comment.