Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker: Fixed month names and firstDay value in Arabic locale #1246

Closed
wants to merge 1 commit into from
Closed

Datepicker: Fixed month names and firstDay value in Arabic locale #1246

wants to merge 1 commit into from

Conversation

dralshehri
Copy link

Fixes #10035

@tjvantoll
Copy link
Member

Hi @dralshehri,

Can you please sign our CLA so we can review this? Thanks.

@dralshehri
Copy link
Author

I've just signed the CLA.

@scottgonzalez
Copy link
Member

Can you provide some insight into the changes for http://bugs.jqueryui.com/ticket/6676?

@dralshehri
Copy link
Author

Well, it's 3 years, and what has been changed since then is that all Arabic countries except 3 countries starts their workweeks on Sunday. So, we should go with the majority and make the firstDay variable = 0 until you use the CLDR and have a specific locale for each country.

@dralshehri
Copy link
Author

Have a look over this page http://en.wikipedia.org/wiki/Workweek_and_weekend

@scottgonzalez
Copy link
Member

We'll land this for 1.12.0.

@scottgonzalez scottgonzalez added this to the 1.12 milestone Aug 27, 2014
@scottgonzalez
Copy link
Member

We're ready to land this, but you signed the CLA with a different email address than the one you used in git. Please let us know which address you want to use. If it's the one in git, you'll need to sign the CLA again.

@dralshehri
Copy link
Author

Sorry, I missed that. I'll go with the one I use on GitHub.I'll try to sign the CLA within hours.

—Mohammed Alshehri

On Tue, Oct 21, 2014 at 9:33 PM, Scott González notifications@github.com
wrote:

We're ready to land this, but you signed the CLA with a different email address than the one you used in git. Please let us know which address you want to use. If it's the one in git, you'll need to sign the CLA again.

Reply to this email directly or view it on GitHub:
#1246 (comment)

@scottgonzalez
Copy link
Member

You signed with the same email address you signed with last time. Is that the address you want to use? You have git configured to use Gmail.

@dralshehri
Copy link
Author

I'm sorry I did that again :)

I've just signed using the same email I use for Github. I think it's ok now.

@scottgonzalez
Copy link
Member

Well, now you've signed three times with the same email address. I'm going to use that addres and change the commit info.

arschmitz pushed a commit that referenced this pull request Nov 7, 2014
scottgonzalez pushed a commit that referenced this pull request Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants