Resizable: alsoResize more than one element of a jQuery selection #1324
Conversation
|
Hey @benmosher, Can you please sign our CLA so we can take a look at this? Thanks. |
|
@benmosher Thanks for contirbuting! Besides for signing our CLA, it would be great if this change came with some unit tests. I know the test suite for resizable is kind of anemic at the moment, but it would be very very helpful. Think you can do that? Thanks again! |
|
Signed the CLA. I will add unit tests if I get a chance 😎 |
|
Heads up: added unit tests a while ago. I'm not sure if that generates any alerts or if anything else is needed here. |
| @@ -1040,14 +1028,7 @@ $.ui.plugin.add("resizable", "alsoResize", { | |||
| el.css(style); | |||
| }); | |||
| }; | |||
|
|
|||
| if (typeof(o.alsoResize) === "object" && !o.alsoResize.nodeType) { | |||
| $.each(o.alsoResize, function(exp, c) { | |||
There was a problem hiding this comment.
It looks like this was supporting an undocumented format of the option where the keys were selectors and the values were contexts to search in. I'm ok dropping this since I don't think this was ever documented, but we should be aware of it.
Fixes #4666.
Did not cause any (new) tests to fail. Several tests were failing on my machine when I pulled the project and set up per the readme (including two [unrelated?] resizable tests).
The selector syntax used in the implementations of
_storeand_alsoResizeappear to be semantically identical to the removed code (sans theo.alsoResize[0]) and function as expected in my personal use.