Resizable: Modified to allow jquery objects as handles. Fixed #9658: #1377
Conversation
…Custom handlers did not work as jquery objects (outside the resizable element)
| @@ -199,6 +204,9 @@ $.widget("ui.resizable", $.ui.mouse, { | |||
| if (this.handles[i].constructor === String) { | |||
| this.handles[i] = this.element.children( this.handles[ i ] ).first().show(); | |||
| } | |||
| else if (this.handles[i] instanceof $) { | |||
There was a problem hiding this comment.
This should also support DOMElements directly.
|
Hi @patrixd, and thanks for this. I verified your change works for jQuery objects but this change should also support DOMElements. Also make sure your code adheres to our style guide. If you run |
|
Thank you @tjvantoll for your assistance, I changed the code and now it supports DOMElements. |
| @@ -199,6 +204,10 @@ $.widget("ui.resizable", $.ui.mouse, { | |||
| if (this.handles[i].constructor === String) { | |||
| this.handles[i] = this.element.children( this.handles[ i ] ).first().show(); | |||
| } | |||
| else if (this.handles[i] && (this.handles[i].jquery || this.handles[i].nodeType)) { | |||
There was a problem hiding this comment.
The first check here this.handles[i].jquery is unnecessary. The previous check is already looking at this.handles[i].constructor.
|
There are a bunch of style things to clean up, but other that and one small comment I listed above this looks good to me. |
Rebased