Sortable: Redetermine floating flag when recalculating positions #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjvantoll
force-pushed
the
sortable-floating-fix
branch
from
932c644
to
cdbcd83
Compare
This addresses a bug where users initialize empty sortable lists are add items dynamically. In this situation refresh() should recognize the position and orientation of the new items. Fixes #7498 Closes jquerygh-1381
tjvantoll
force-pushed
the
sortable-floating-fix
branch
from
cdbcd83
to
694da19
Compare
| element = $( "#qunit-fixture" ).html( "<ul></ul>" ).find( "ul" ); | ||
|
|
||
| element | ||
| .css({ "float": "left", width: "100px" }) |
There was a problem hiding this comment.
Split each property to its own line. Apples to the call below too.
|
Addressed all comments. |
|
Looks good to me. |
tjvantoll
added a commit
that referenced
this pull request
Nov 7, 2014
This addresses a bug where users initialize empty sortable lists are add items dynamically. In this situation refresh() should recognize the position and orientation of the new items. Fixes #7498 Closes gh-1381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug where users initialize empty sortable lists are
add items dynamically. In this situation refresh() should recognize the
position and orientation of the new items.
Fixes #7498