Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: Suppress automatic activation when navigating with COMMAND #1383

Closed
wants to merge 1 commit into from
Closed

Tabs: Suppress automatic activation when navigating with COMMAND #1383

wants to merge 1 commit into from

Conversation

scottgonzalez
Copy link
Member

Fixes #9621

@tjvantoll
Copy link
Member

The functionality for this looks fine. It might be nice to have a comment before the $.each in the tests, because it took me a couple of minutes to figure out what was going on there.

@scottgonzalez
Copy link
Member Author

Added a comment above the tests.

scottgonzalez added a commit that referenced this pull request Nov 7, 2014
@scottgonzalez @arschmitz
Tabs: Suppress automatic activation when navigating with COMMAND
d6e06b5 
Fixes #9621
Closes gh-1383
scottgonzalez added a commit that referenced this pull request Feb 9, 2015
@scottgonzalez
Tabs: Suppress automatic activation when navigating with COMMAND
9dd1e73 
Fixes #9621
Closes gh-1383
(cherry picked from commit 6a242ab)
@scottgonzalez scottgonzalez deleted the tabs-command-key branch February 24, 2015 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottgonzalez @tjvantoll