Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sortable: add support for iframes #1443

Closed
wants to merge 2 commits into from
Closed

Sortable: add support for iframes #1443

wants to merge 2 commits into from

Conversation

marcuswarrenca
Copy link
Contributor

Changed several instances of document / window to use internally referenced versions
Found this related ticket: http://bugs.jqueryui.com/ticket/9604

Fixes #9604

@marcuswarrenca
Sortable: add support for iframes
d90b441 
Changed several instances of document to use internally referenced document
http://bugs.jqueryui.com/ticket/9604

Fixes #9604
@scottgonzalez
Copy link
Member

Thanks, can you change all of the $(this.document[0]) instances to just this.document? It doesn't make sense to drop down to the DOMElement just to re-wrap.

@marcuswarrenca
Sortable: add support for iframes
280b91a 
Corrections to avoid unnecessary wrapping.
@marcuswarrenca
Copy link
Contributor Author

Sounds good, this is done.

@scottgonzalez
Copy link
Member

Thanks, I squashed the commits and fixed your name in the author info. If you're interested in sending more patches in the future, it'd be great if you could update your git config to use your full name rather than your username.

@marcuswarrenca
Copy link
Contributor Author

I'll do that, thanks.

scottgonzalez pushed a commit that referenced this pull request Feb 9, 2015
@marcuswarrenca @scottgonzalez
Sortable: Add support for iframes
fa460f3 
Fixes #9604
Closes gh-1443
(cherry picked from commit 17c7f69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcuswarrenca @scottgonzalez