Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cleanup-list-numbers infinite loop #100

Merged
merged 1 commit into from
Feb 19, 2016
Merged

fix cleanup-list-numbers infinite loop #100

merged 1 commit into from
Feb 19, 2016

Conversation

cosmicexplorer
Copy link
Contributor

This fixes the case given in #98. However, I couldn't reproduce #98 noninteractively; I'll look for a way to do that.

@syohex
Copy link
Collaborator

syohex commented Feb 19, 2016

I confirmed #98 issue is fixed with this PR.

However, I couldn't reproduce #98 noninteractively;

It looks replace-match behavior is different between interactive-mode and non-interactive-mode.

I'll look for a way to do that.

Thanks. We should add regression test about this.

syohex added a commit that referenced this pull request Feb 19, 2016
@syohex
Merge pull request #100 from cosmicexplorer/fix/line-numbering-loop
3e88d58 
fix cleanup-list-numbers infinite loop
@syohex syohex merged commit 3e88d58 into jrblevin:master Feb 19, 2016
@syohex syohex mentioned this pull request Feb 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosmicexplorer @syohex