Fix/cleanup eww live export #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the the CI is failing; if you look at the details, it appears to be some issue with cask? I'm not 100% sure. It seems to work on my local copy of 24.3. Not sure what to do here, there doesn't seem to be a way to restart the CI. |
|
Ok, looks like this passed now. The failures earlier were weird, though. |
|
Looks like it may have been a fluke related to pulling down Cask anew each time. It looks good to me now also. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes more sense to check whether
'eww-open-fileis actually bound than all of'eww. Also, I left some test code in.