Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat backslashes as escapes inside literal blocks #768

Merged
merged 1 commit into from
May 22, 2023

Conversation

jimporter
Copy link
Contributor

Description

Backslashes get fontified as markup characters in too many situations. In particular, a backslash inside a literal block (e.g. code, math) should just be a literal backslash, not the introducer of an escape sequence.

It might be worthwhile to add some further regression tests here, but the one I did add fails without the fix, and passes with it.

Related Issue

See #766.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have updated the documentation in the README.md file if necessary.
  • I have added an entry to CHANGES.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed (using make test).

@syohex syohex merged commit 0031a92 into jrblevin:master May 22, 2023
@jimporter jimporter deleted the literal-no-escape branch March 9, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants