Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:bd on vimagit error #130

Closed
abaldwin88 opened this issue Mar 17, 2017 · 5 comments
Closed

:bd on vimagit error #130

abaldwin88 opened this issue Mar 17, 2017 · 5 comments
Labels

Comments

@abaldwin88
Copy link

abaldwin88 commented Mar 17, 2017

I commonly use :bd to close vimagit (hard to overcome that muscle memory and use Q)

This has been working fine for months when I was using commit cafba10. Recently I upgraded to commit 5921ef4 and now I am getting an error. Here are my steps:

Modify a file --> Open Magit with :Magit --> Stage file --> close with :bd --> Open again with :Magit --> error

(This is happening in a brand new repo. Just started it with git init .)

Note: I do not see this error if I close with Q.

Error detected while processing BufEnter Auto commands for "magit:///Users/abaldwin/blarg/":
E121: Undefined variable: b:magit_current_commit_mode

OSX 10.11.6
iTerm 3.0.15
nvim 0.1.7
vimagit 5921ef4

P.S.

Awesome plugin by the way 👍

@jreybert
Copy link
Owner

jreybert commented Mar 17, 2017

Thanks for such a wonderful bug report!

You screw up all my buffer scoped variables with your :bd :)

@jreybert jreybert added the bug label Mar 17, 2017
@guyzmo
Copy link

guyzmo commented May 19, 2017

just for the note: I'm getting the same error. Actually, I'm not exactly using :bd but :Bdelete which is like :bd as it closes the buffer, but not the current window.

(I'm actually only using :MagitOnly, and I'd like to either get rid of q or at least make it close the Magit buffer not the current split window)

@jreybert
Copy link
Owner

jreybert commented May 23, 2017

Hu @guyzmo , could you please open a new issue for your MagitOnly issue please?

EDIT: actually, thi issue already exists here: #132

EDIT2: #132 was too broad, now in #137 Could you please give it a try?

@abaldwin88
Copy link
Author

Just pulled down the fix. Works like a charm 👍

@jreybert
Copy link
Owner

jreybert commented Aug 8, 2017

Merged in master and present in release 1.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants