Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for close section for commit #55

Merged
merged 4 commits into from
Dec 14, 2015

Conversation

bakunyo
Copy link
Contributor

@bakunyo bakunyo commented Dec 12, 2015

This is an alternative PR #54

@jreybert
Copy link
Owner

Thanks bakunyo!

I merge it, but there is still something. You write well the ongoing commit message in COMMIT_EDITMSG, but I remember just now that I discard this file before opening the commit section wirth 'CC'. Then, what have been written in COMMIT_EDITMSG is lost.

I do not expect that the user use 'CA' after a 'CU' to retrieve the ongoing commit message. I do not want either a complex state machine in vimagit to discard or not the COMMIT_EDITMSG after a 'CC'.

I will investigate the precise COMMIT_EDITMSG behavior. My first lead will be to look at how git gui works (git gui save the current commit message). Anyway, if you still want to work on this, do not hesitate :)

jreybert added a commit that referenced this pull request Dec 14, 2015
Commit 'Write commit message to .git/COMMIT_EDITMSG' must be completed.
@jreybert jreybert merged commit 35570fa into jreybert:next Dec 14, 2015
@bakunyo
Copy link
Contributor Author

bakunyo commented Dec 15, 2015

@jreybert Thank you for merging this PR!
I have known the existence of COMMIT_EDITMSG, so I pleased.
I will send other PR if I get a change!

@bakunyo bakunyo deleted the close-commit-for-next branch December 15, 2015 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants