Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/magit.vim: suppress more 'line added' messages #56

Merged
merged 1 commit into from
Dec 18, 2015
Merged

plugin/magit.vim: suppress more 'line added' messages #56

merged 1 commit into from
Dec 18, 2015

Conversation

joelmo
Copy link
Contributor

@joelmo joelmo commented Dec 15, 2015

No description provided.

@jreybert
Copy link
Owner

Seems good to me. Don't trust travis integration, it is quite broken these days.

I'll merge this PR soon.

@jreybert
Copy link
Owner

Hi joelmo,

some remarks:

  1. your PR does not hurt, it seems fine to me to merge it. Anyway, I would like to understand your current vim setup. Without your commit, I do not notice any 'line added' message. Could you please tell me your vim version, and if you have a partucular vim setting around message verbosity.
  2. could you please rebase your commit upon the branch next the repush a pull request?

Thanks for your work!

@joelmo
Copy link
Contributor Author

joelmo commented Dec 18, 2015

Thanks. I really like this plugin!

I use this version of vim:
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jan 01 1970 00:00:01)
Included patches: 1-826
Compiled by nixbld
Huge version with GTK2 GUI.

Ignore that date, all my binaries have that because I use nix.

I think I saw these messages because I had the setting: set report=0. But anyway I think these puts should be called with silent or maybe temporarily set the setting 'report' to 2 or higher. Because these messages are not useful.

@jreybert
Copy link
Owner

Glad to hear that you like it ☺

agree that these message are useless, I just would like to be able to reproduce this behavior. I'll try with your setting.

jreybert added a commit that referenced this pull request Dec 18, 2015
plugin/magit.vim: suppress more 'line added' messages

set report=0 to see extra messages
@jreybert jreybert merged commit c5e02fb into jreybert:master Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants