Rework Encryption to enable future support of other encryption methods #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: jrnl/output.py
micahellison
previously approved these changes
Oct 8, 2022
|
This looks great. Let's plan on re-running tests then merging this after we drop Python 3.9 in #1611. |
wren
force-pushed
the
encryption-rework
branch
from
0710eab
to
d066a3a
Compare
wren
changed the title
Conflicts: jrnl/Journal.py jrnl/commands.py
4 tasks
Conflicts: jrnl/output.py jrnl/prompt.py
wren
force-pushed
the
encryption-rework
branch
from
493cfe9
to
12bcc64
Compare
There was a new test added for re-encrypting a journal. This updates the refactor to match the old (previously untested) behavior of jrnl. Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>
micahellison
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to rework how
jrnldoes encryption in such a way that makes it easier for us to support multiple encryption methods. It should also make it easier to enable encryption support on other journal types (directory journal, DayOne, etc).Fixes:
It does not fix, but lays the groundwork to fix the following issues in the near future:
Checklist
for the same issue.