Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug for new --list --format options when no default journal is specified #1621

Merged
merged 5 commits into from
Oct 22, 2022
Merged

Fix bug for new --list --format options when no default journal is specified #1621

merged 5 commits into from
Oct 22, 2022

Commits on Oct 22, 2022

  1. rename test config

    @wren
    wren committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    3ac2b95 View commit details
    Browse the repository at this point in the history

  2. Change journal name validation 

    Journal name validation used to happen before postconfig commands could
have a chance to run, so now each command is responsible for its own
error-checking of the journal name.

Added a new decorator and function that makes this error-checking easier.

Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>
    @wren @micahellison
    wren and micahellison committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    2130af2 View commit details
    Browse the repository at this point in the history

  3. fix wrapper function call to be more like original

    @wren
    wren committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    37f2c44 View commit details
    Browse the repository at this point in the history

  4. change arg names to show which aren't used

    @wren
    wren committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    ceefc0c View commit details
    Browse the repository at this point in the history

  5. add type hints

    @wren
    wren committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    3d207d7 View commit details
    Browse the repository at this point in the history