Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rich handler to debug logging #1627

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

wren
Copy link
Member

@wren wren commented Oct 30, 2022

This PR adds small, quality-of-life improvements to the debug logging. As we add more logging, this will see even more benefit. See below for before and after screenshots.

Before:

Screen Shot 2022-10-30 at 11 46 32 AM

After:

Screen Shot 2022-10-30 at 11 47 10 AM

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it's so much more readable! Looks good on Windows too.

@micahellison micahellison added the enhancement New feature or request label Oct 31, 2022
@micahellison micahellison merged commit cd47070 into jrnl-org:develop Oct 31, 2022
@micahellison micahellison deleted the debug-handler branch October 31, 2022 15:55
@alichtman
Copy link
Contributor

Thanks @wren! Way easier to read the debug log now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants