Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation on temporary files naming #1673

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Update documentation on temporary files naming #1673

merged 1 commit into from
Feb 11, 2023

Conversation

giuseppedandrea
Copy link
Contributor

According to the documentation, temporary files are named jrnl_*.txt.
Actually, from #1139, temporary files are named jrnl*.jrnl.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

@giuseppedandrea giuseppedandrea changed the title docs: update temporary file suffix Update documentation on temporary files naming Feb 10, 2023
micahellison
micahellison approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching and fixing this!

@micahellison micahellison added the documentation Improvements or additions to documentation label Feb 11, 2023
@micahellison micahellison merged commit 2d1a52a into jrnl-org:develop Feb 11, 2023
@giuseppedandrea giuseppedandrea deleted the docs/tmpfile-suffix branch February 11, 2023 20:15
wren pushed a commit to wren/jrnl that referenced this pull request Mar 4, 2023
@giuseppedandrea @wren
Update documentation on temporary files naming (jrnl-org#1673)
905a9ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giuseppedandrea @micahellison