Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only read text files that look like entries when opening folder journal #1697

Merged
merged 15 commits into from
Apr 29, 2023
Merged

Only read text files that look like entries when opening folder journal #1697

merged 15 commits into from
Apr 29, 2023

Commits on Mar 2, 2023

  1. Add text file that should be ignored to basic test folder journal. Ma… 

    …kes tons of tests fail
    @micahellison
    micahellison committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    16be83d View commit details
    Browse the repository at this point in the history

  2. Add additional files that should be ignored by FolderJournal

    @micahellison
    micahellison committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    ba3622f View commit details
    Browse the repository at this point in the history

  3. Ignore all files in folder journal except year/month/day.txt

    @micahellison
    micahellison committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    c5236fe View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Completely remake get_files in FolderJournal: 

    - move get_files into FolderJournal class and add underscore prefix
- create iterables to get for year/month folders and day files
- make year/month/day file reading strict: only exact expected months and days out of all possible months and days
    @micahellison
    micahellison committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    93e475b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into folder-journal-file-read-1692

    @micahellison
    micahellison committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    a21f3e1 View commit details
    Browse the repository at this point in the history

  3. Restore accidentally-deleted self.sort() line

    @micahellison
    micahellison committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    c749cae View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Use match instead of string comparison to be os-agnostic

    @micahellison
    micahellison committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    92aa660 View commit details
    Browse the repository at this point in the history

  2. Explicitly declare static methods

    @micahellison
    micahellison committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    194a379 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. Merge branch 'develop' into folder-journal-file-read-1692

    @micahellison
    micahellison committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    034aaed View commit details
    Browse the repository at this point in the history

  2. Filter with glob first for max performance

    @micahellison
    micahellison committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    128cd16 View commit details
    Browse the repository at this point in the history

  3. Explicitly check for valid dates in FolderJournal and add unit test

    @micahellison
    micahellison committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    542781d View commit details
    Browse the repository at this point in the history

  4. Remove unneeded jrnl import

    @micahellison
    micahellison committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    b0da4e1 View commit details
    Browse the repository at this point in the history

  5. Clean up method comment and add type hints

    @micahellison
    micahellison committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    36b9b79 View commit details
    Browse the repository at this point in the history

  6. Add is_valid_date unit test

    @micahellison
    micahellison committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    bb96b0b View commit details
    Browse the repository at this point in the history

  7. Elucidate comment

    @micahellison
    micahellison committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    3a2d466 View commit details
    Browse the repository at this point in the history