-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor --template code #1711
Refactor --template code #1711
Conversation
…DD tests are failing
… in editor and unify those two use cases. Some tests still failing
…side effects that caused unit tests to fail on some platforms
In an attempt to fix this, I removed the Path return values in favor of strings. I like that it's more consistent with the rest of the code base (though I do like pathlib in theory), however the tests are still failing. It looks like the problem is that the current directory is needed for os.path.abspath to work, but it somehow doesn't exist while running unit tests on Linux. I'm not sure what's going on there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Fixes #1736 and #1737.
Re-organizes some of the template code from #1667. Moving template concerns out of controller.py where possible.
Checklist
for the same issue.