-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable vaapi, to support hardware acceleration #106
Conversation
templates/Dockerfile-template.ubuntu
Outdated
@@ -61,5 +62,10 @@ ENV LD_LIBRARY_PATH=/usr/local/lib | |||
|
|||
COPY --from=build /usr/local /usr/local/ | |||
|
|||
RUN \ | |||
apt-get update -y && \ | |||
apt-get install -y libva-drm1 libva1 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runtime dependency ?
Just for ubuntu ? That would explain the failure on https://travis-ci.org/jrottenberg/ffmpeg/builds/389354692 though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be move into the base container to avoid an extra layer
Thanks a lot for your contribution it was on my todo list for a while and was requested like on #27 |
@jrottenberg I've fixed the CentOS and Alpine builds by installing libva in the target container. Travis shows a couple of errors; that seems to be because of file download issues. |
It looks great, thank you. One more commit andI'll merge : remove templates/.Dockerfile-env.swp |
oh !
I wonder if we should make a variant for that build ... |
@jrottenberg Using
The recommended part contains the |
ok I really want to merge it , but it touches too many images, would you be ok to create a new variant based on ubuntu named :
|
Yes, sure, I'm using the Ubuntu variant anyway. |
* Enable vaapi * Add libva * Don't install recommended packages
This PR adds the
--enable-vaapi
flag, and builds FFmpeg with support for (Intel) hardware acceleration.The Ubuntu, CentOS and Alpine images have also been updated to include the build-time vaapi dependencies.