Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The defpackage does not understand export #288

Closed
foretspaisibles opened this issue Oct 1, 2017 · 1 comment
Closed

The defpackage does not understand export #288

foretspaisibles opened this issue Oct 1, 2017 · 1 comment

Comments

@foretspaisibles
Copy link
Contributor

It looks like the defpackage macro does not understand :export clauses. When attempting to define a package with a :export clause the following error condition is met:

; Evaluation aborted on #<SB-KERNEL:CASE-FAILURE expected-type: "(MEMBER :USE)"datum: :EXPORT>.

This seems to refer to the code in package.lisp

(defmacro defpackage (package &rest options)
  (let (use)
    (dolist (option options)
      (ecase (car option)
        (:use
         (setf use (append use (cdr option))))))
    `(progn
       (eval-when (:load-toplevel :execute)
         (%defpackage ',(string package) ',use))
       (eval-when (:compile-toplevel)
         (make-package ',(string package) :use ',use)))))

Would it be enough to iterate over the provided symbols using the export function or would more care be needed?

foretspaisibles added a commit to foretspaisibles/jscl that referenced this issue Oct 17, 2017
Note that the MAKE-PACKAGE function purposely does not support that
keyword.

See http://clhs.lisp.se/Body/f_mk_pkg.htm

Closes jscl-project#288.
foretspaisibles added a commit to foretspaisibles/jscl that referenced this issue Oct 17, 2017
Note that the MAKE-PACKAGE function purposely does not support that
keyword.

See http://clhs.lisp.se/Body/f_mk_pkg.htm
@foretspaisibles
Copy link
Contributor Author

#293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant