Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entering unbalanced parentheses causes infinite loop in web worker REPL #318

Closed
HenryS1 opened this issue May 7, 2018 · 0 comments
Closed

Entering unbalanced parentheses causes infinite loop in web worker REPL #318

HenryS1 opened this issue May 7, 2018 · 0 comments
Labels
bug

Comments

@HenryS1
Copy link
Contributor

HenryS1 commented May 7, 2018

Entering ) at the prompt causes the REPL to go into a loop printing errors. This is because read doesn't consume a char when it encounters an EOF Error.

screen shot 2018-05-07 at 9 52 27 pm
HenryS1 added a commit to HenryS1/jscl that referenced this issue May 7, 2018
@HenryS1
read char on EOF to prevent REPL infinite loop
ddc4c0a 
This fixes jscl-project#318
@HenryS1 HenryS1 mentioned this issue May 7, 2018
Closed
@davazp davazp added the bug label May 7, 2018
HenryS1 added a commit to HenryS1/jscl that referenced this issue May 8, 2018
@HenryS1
changed error message on unbalanced parenthesis
488d949 
fixes jscl-project#318
HenryS1 added a commit to HenryS1/jscl that referenced this issue May 8, 2018
@HenryS1
clearing buffer for web worker REPL on error
ee48eaa 
fixes jscl-project#318
@davazp davazp closed this as completed in 07fa4f3 May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

read char on EOF to prevent REPL infinite loop HenryS1/jscl
2 participants
@davazp @HenryS1