Vkm add some missing functions (#330) #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
every replaced by more sequences version
davazp
requested changes
Oct 15, 2018
src/list.lisp
Outdated
| (defun union (list1 list2 &key key (test #'eq)) | ||
| (cond ((and list1 list2) | ||
| (let ((result (makeset list2 :test #'equal))) | ||
| (dolist (it (makeset list1 :test #'equal)) |
There was a problem hiding this comment.
Do you actually need makeset for the dolist? here? I don't think so. And it would probably be faster if you don't call it.
There was a problem hiding this comment.
Thanks!
These are my cats on the keyboard ran :)
There was a problem hiding this comment.
About indentation - accepted. That's my fault.
In my standard uses lisp-body-indentation 4, but for JSCL PR I will use indent for 2 positions. Perhaps individual keywords will be with indented 1, sorry, each emacs has their own habits.
|
Thanks for review. |
added commentary added (vectorp) check with error
davazp
approved these changes
Oct 21, 2018
davazp
approved these changes
Oct 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
sort(implementation only for lists, others in TODO) in list.lispset-differencein list.lispunionin list.lispremove-duplicatesin sequence.lispeveryin sequence.lisp replaced by more sequences versionReasons