Skip to content
This repository has been archived by the owner on Dec 29, 2020. It is now read-only.

Update jscs to 3.0 #122

Closed
wants to merge 1 commit into from
Closed

Update jscs to 3.0 #122

wants to merge 1 commit into from

Conversation

paladox
Copy link
Contributor

@paladox paladox commented Apr 18, 2016

Jscs is now deprecated and will no longer be updated.

It will only have bug fixes for three months and instead they are moving to eslint.

Jscs is now deprecated and will no longer be updated.

It will only have bug fixes for three months and instead they are moving to eslint.
@gustavohenke
Copy link
Member

Could you please take a look on the errors that are going on in the unit tests?

@tclindner
Copy link

@paladox would you mind reviewing your PR? I'm interested in your update!

@markelog
Copy link
Member

markelog commented May 14, 2016

Yeah, i was waiting to do the support for 3.x release but it was shaky for a while, still is though, i'm hoping incoming 3.0.4 would cover most of the issues

@paladox
Copy link
Contributor Author

paladox commented May 14, 2016

Ok, I'm not sure why it is failing

I'm getting this in 0.10

236Testing methods.js...............Warning: Object # has no method 'getSourceCodeLength'� Use --force to continue.

and this in 0.12

236Testing methods.js...............Warning: undefined is not a function� Use --force to continue.

and this in 4 and 5

238Testing methods.js...............Warning: element.getSourceCodeLength is not a function� Use --force to continue.

@paladox
Copy link
Contributor Author

paladox commented May 14, 2016

@CheungJ CheungJ mentioned this pull request May 25, 2016
@markelog markelog closed this in 4f2cbe2 Jun 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants